Skip to content

fix: merge close same-net parallel trace segments#188

Open
liufang88789-ui wants to merge 2 commits intotscircuit:mainfrom
liufang88789-ui:fix/issue-34-merge-close-same-net-traces
Open

fix: merge close same-net parallel trace segments#188
liufang88789-ui wants to merge 2 commits intotscircuit:mainfrom
liufang88789-ui:fix/issue-34-merge-close-same-net-traces

Conversation

@liufang88789-ui
Copy link
Copy Markdown

Summary\n- add a final TraceCleanup pass that merges close, overlapping, parallel internal segments when they belong to the same net\n- keep the change low-risk by skipping terminal segments and requiring both 1D overlap and a small merge-distance threshold\n- add focused tests covering horizontal/vertical merge and the key non-merge cases\n\n## Why\nAfter , same-net traces can end up visually split onto nearby Y/X coordinates. This patch snaps those close internal segments back together without touching different nets or distant/non-overlapping segments.\n\n## Validation\n- \n- bun test v1.3.11 (af24e281)

Dispatch phase complete. Created 0 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 1 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 2 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 2 sub-solvers.
Dispatch phase complete. Created 0 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 1 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 1 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 0 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 1 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 0 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 0 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 0 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 1 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 0 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 0 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 0 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 0 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 0 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 0 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 1 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 0 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 0 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 2 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 0 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 0 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 0 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 0 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 0 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 0 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 0 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 0 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 1 sub-solvers.
All sub-solvers finished.\n\n## Claim\n/claim #34

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 15, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
schematic-trace-solver Ready Ready Preview, Comment Apr 15, 2026 1:17am

Request Review

@liufang88789-ui
Copy link
Copy Markdown
Author

Quick maintainer note: this PR is intentionally kept low-risk and focused.

  • merges only close, overlapping, parallel internal same-net segments
  • skips terminal segments to avoid changing endpoint behavior
  • includes focused tests for both merge and non-merge cases
  • all checks are green

If you'd prefer an even narrower version, I can trim it further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant