fix: merge close same-net parallel trace segments#188
Open
liufang88789-ui wants to merge 2 commits intotscircuit:mainfrom
Open
fix: merge close same-net parallel trace segments#188liufang88789-ui wants to merge 2 commits intotscircuit:mainfrom
liufang88789-ui wants to merge 2 commits intotscircuit:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Author
|
Quick maintainer note: this PR is intentionally kept low-risk and focused.
If you'd prefer an even narrower version, I can trim it further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- add a final TraceCleanup pass that merges close, overlapping, parallel internal segments when they belong to the same net\n- keep the change low-risk by skipping terminal segments and requiring both 1D overlap and a small merge-distance threshold\n- add focused tests covering horizontal/vertical merge and the key non-merge cases\n\n## Why\nAfter , same-net traces can end up visually split onto nearby Y/X coordinates. This patch snaps those close internal segments back together without touching different nets or distant/non-overlapping segments.\n\n## Validation\n- \n- bun test v1.3.11 (af24e281)
Dispatch phase complete. Created 0 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 1 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 2 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 2 sub-solvers.
Dispatch phase complete. Created 0 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 1 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 1 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 0 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 1 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 0 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 0 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 0 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 1 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 0 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 0 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 0 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 0 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 0 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 0 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 1 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 0 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 0 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 2 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 0 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 0 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 0 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 0 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 0 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 0 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 0 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 0 sub-solvers.
All sub-solvers finished.
Dispatch phase complete. Created 1 sub-solvers.
All sub-solvers finished.\n\n## Claim\n/claim #34