fix(session): hydrate SquadSessionID from legacy conversation_id key#73
Open
SAY-5 wants to merge 1 commit into
Open
fix(session): hydrate SquadSessionID from legacy conversation_id key#73SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
Fixes tstapler#38 Signed-off-by: SAY-5 <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #38. The previous
ConversationIDfield used the JSON tagconversation_id; after renaming it toSquadSessionIDwith tagsquad_session_id, persisted state written before the rename failed to hydrate the field on next load.Changes
session/storage.go— add a customUnmarshalJSONonClaudeSessionDatathat reads the legacyconversation_idkey as a fallback forsquad_session_id.squad_session_idstill wins when both keys are present, so newly written state is unaffected.Test plan
go test ./session -run TestClaudeSessionData_UnmarshalJSON— three cases: legacy-only key hydrates, new key wins over legacy, new-only format still works.go vet ./sessionclean.