Skip to content

⚡ perf: Optimize deleteBulk N+1 issue with single IN query #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tstapler wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡ perf: Optimize deleteBulk N+1 issue with single IN query #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion kmp/src/commonMain/kotlin/dev/stapler/stelekit/repository/SqlDelightBlockRepository.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,11 +368,16 @@ class SqlDelightBlockRepository(
}

override suspend fun deleteBulk(blockUuids: List<String>, deleteChildren: Boolean): Either<DomainError, Unit> = withContext(PlatformDispatcher.DB) {
if (blockUuids.isEmpty()) return@withContext Unit.right()
try {
val wikilinkPages = mutableSetOf<String>()
queries.transaction {
val blocks = blockUuids.chunked(900).flatMap { chunk ->
queries.selectBlocksByUuids(chunk).executeAsList()
}
Comment on lines +375 to +377
val blocksByUuid = blocks.associateBy { it.uuid }
blockUuids.forEach { uuid ->
val block = queries.selectBlockByUuid(uuid).executeAsOneOrNull() ?: return@forEach
val block = blocksByUuid[uuid] ?: return@forEach
wikilinkPages.addAll(extractWikilinks(block.content))
if (deleteChildren) {
// Collect the full subtree
Expand Down
3 changes: 3 additions & 0 deletions kmp/src/commonMain/sqldelight/dev/stapler/stelekit/db/SteleDatabase.sq
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -922,3 +922,6 @@ INSERT OR REPLACE INTO git_config(

deleteGitConfig:
DELETE FROM git_config WHERE graph_id = ?;

selectBlocksByUuids:
SELECT * FROM blocks WHERE uuid IN ?;
Loading