Take updates for new US area codes and i18n number format changes#127
Open
dbhoot wants to merge 1 commit intottacon:masterfrom
Open
Take updates for new US area codes and i18n number format changes#127dbhoot wants to merge 1 commit intottacon:masterfrom
dbhoot wants to merge 1 commit intottacon:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
The library did not recognize / support many new numbers. For example, the new 945 area code in the dallas area.
https://ftp.puc.texas.gov/public/puct-info/agency/resources/pubs/news/2021/PUCTX-MR-PR-TEL-945-Begins-FIN.pdf
Now
It does.
I just ran an update to pull the latest from google libphone number. Some tests failed but I double checked the values and the lib is returning the correct values, so I updated the tests.
Also adds go mod
I'm sure this will fix many open issues.
Notes
I reimplemented the isLeadingZeroPossible function.
The metadata value that it was relying on was removed from the protocol buffer.