-
Notifications
You must be signed in to change notification settings - Fork 3
Feature/pattern change detection #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
…, STPH) with real-time GUI dashboard
…, STPH) with real-time GUI dashboard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are several points that need to be fixed before merging.
Several things mentioned under https://github.com/tuda-parallel/FTIO/blob/feature/pattern_change_detection/docs/students_contribute.md are missing. This includes:
- Documentation and license for new files: https://github.com/tuda-parallel/FTIO/blob/feature/pattern_change_detection/docs/students_contribute.md#-module-documentation-and-licensing
- Adding test cases: https://github.com/tuda-parallel/FTIO/blob/feature/pattern_change_detection/docs/students_contribute.md#-module-documentation-and-licensing
- Adding a documentation: https://github.com/tuda-parallel/FTIO/blob/feature/pattern_change_detection/docs/students_contribute.md#-module-documentation-and-licensing
A-Tarraf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some open ToDos
|
It looks much better! Thank you for your changes. Could you just maybe:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks much better! Thank you for your changes. Could you just maybe extend and test the documentation? 1. I tried the call predictor X.jsonl -e no -f 100 -w frequency hits --online_adaptation adwin but it did not work. I think the problem was frequency_hits.
2. Include also a documentation on how the GUI works and how it automatically connects. I was also wondering how I can display multiple predictions at once and what the bandwidth over time of the original signal looks like. The old plots from FTIO always include both the predictions and the original signal.
3. Maybe only enable to forward data to the gui if an explicit argument (--gui) is passed
4. Include a callpath tree of the function used like here: https://github.com/tuda-parallel/FTIO/blob/development/docs/metric_proxy_zmq.md#call-tree
| def get_change_detector(shared_resources: SharedResources, algorithm: str = "adwin"): | ||
| console = Console() | ||
| algo = (algorithm or "adwin").lower() | ||
| global _local_detector_cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder why you need to use global if we have the shared resource class. You do not necessarily ned to modify this.
Implementation of the three adaptive change point detection algorithms with a real-time visualization dashboard.
Algorithms: ADWIN, AV-CUSUM, STPH