Skip to content

Conversation

@A-Aherbil
Copy link
Collaborator

Implementation of the three adaptive change point detection algorithms with a real-time visualization dashboard.

Algorithms: ADWIN, AV-CUSUM, STPH

@A-Aherbil A-Aherbil linked an issue Jan 12, 2026 that may be closed by this pull request
@A-Aherbil A-Aherbil changed the base branch from main to development January 14, 2026 23:44
@A-Aherbil A-Aherbil closed this Jan 14, 2026
@A-Aherbil A-Aherbil reopened this Jan 14, 2026
Copy link
Member

@A-Tarraf A-Tarraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@A-Tarraf A-Tarraf added the feature feature request label Jan 15, 2026
@A-Aherbil A-Aherbil requested a review from A-Tarraf January 21, 2026 23:24
Copy link
Member

@A-Tarraf A-Tarraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some open ToDos

@A-Aherbil A-Aherbil requested a review from A-Tarraf January 22, 2026 15:23
@A-Tarraf
Copy link
Member

A-Tarraf commented Jan 27, 2026

It looks much better! Thank you for your changes. Could you just maybe:

  1. Extend and test the documentation? I tried the call predictor X.jsonl -e no -f 100 -w frequency hits --online_adaptation adwin but it did not work. I think the problem was frequency_hits.
  2. Include also a documentation on how the GUI works and how it automatically connects. I was also wondering how I can display multiple predictions at once and what the bandwidth over time of the original signal looks like. The old plots from FTIO always include both the predictions and the original signal.
  3. Maybe only enable to forward data to the gui if an explicit argument (--gui) is passed

Copy link
Member

@A-Tarraf A-Tarraf Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks much better! Thank you for your changes. Could you just maybe extend and test the documentation? 1. I tried the call predictor X.jsonl -e no -f 100 -w frequency hits --online_adaptation adwin but it did not work. I think the problem was frequency_hits.
2. Include also a documentation on how the GUI works and how it automatically connects. I was also wondering how I can display multiple predictions at once and what the bandwidth over time of the original signal looks like. The old plots from FTIO always include both the predictions and the original signal.
3. Maybe only enable to forward data to the gui if an explicit argument (--gui) is passed
4. Include a callpath tree of the function used like here: https://github.com/tuda-parallel/FTIO/blob/development/docs/metric_proxy_zmq.md#call-tree

def get_change_detector(shared_resources: SharedResources, algorithm: str = "adwin"):
console = Console()
algo = (algorithm or "adwin").lower()
global _local_detector_cache
Copy link
Member

@A-Tarraf A-Tarraf Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why you need to use global if we have the shared resource class. You do not necessarily ned to modify this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature feature request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feature: Add adaptive windowing for pattern change detection

3 participants