[pull] master from php:master#935
Merged
Merged
Conversation
* Deprecate making `__debugInfo()` nullable Returning `null` is already deprecated since PHP 8.5 (3dc962b). Not deprecating a corresponding return type seems like an oversight. * NEWS / UPGRADING
* PHP-8.4: ext/intl: Fix out-of-bounds argument positions in calendar date/time APIs.
* PHP-8.5: ext/intl: Fix out-of-bounds argument positions in calendar date/time APIs.
The previous code computed `Z_STRLEN_P(myval) + ZSTR_LEN(decoded_value)` as a plain `size_t` addition before passing the result to zend_string_extend(), which can wrap on 32-bit and lead to a heap overflow in the following strncpy(). Switch to zend_string_safe_realloc() so the size computation is bounds-checked. close GH-22056
* PHP-8.4: ext/xml: Use zend_string_safe_realloc() for cdata concatenation.
* PHP-8.5: ext/xml: Use zend_string_safe_realloc() for cdata concatenation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )