Bump vnu-jar from 25.11.25 to 25.12.20#41963
Draft
julien-deramond wants to merge 2 commits intomainfrom
Draft
Conversation
Member
|
thought i was having deja-vu ... my fix for the offcanvas there twbs/icons#2222 |
Member
|
for offcanvas (and presumably modal is the same), we should have an appropriate |
Member
Author
|
Thanks for the analysis and all the info @patrickhlauke 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bumps the
vnu-jardev dependency from 25.11.25 to 25.12.20.This new version of
vnu-jarraises the new following errors that can be seen while runningnpm run docs:Errors log (extract)
Analysis
Different use cases are present in these errors.
Warning
6fe6a76 is not a fix! It allows to spot where the issues raised by
vnu-jarare located!There seems to be two kinds of issues:
aria-labelledbyattribute for the<div>s related to modals and offcanvasesrole="tab"without anyaria-controls(or any other modifications)I'm not sure yet if these are false positives and would need to be hidden, or if we'd need to modify some examples/usages.
/cc @patrickhlauke