Fix: Color Mode Switcher shows wrong icon in auto mode #546

[nenadvicentic]

Root cause (different handling for null and auto values) contributes to occasional flickering.

[julien-deramond]

Thanks for the PR! Apologies for the delay in reviewing it. I’ve tested it but wasn’t able to reproduce the occasional flickering issue that could happen in the main branch. I’m going to close this for now, but if you can provide more detailed steps or additional context, feel free to comment here and we’ll gladly reopen it.

[nenadvicentic]

Hi @julien-deramond

Apologies for not so clear pull request description. Regardless of flickering issue (which turned out to be present only in Chrome, not in FF, when script tag is in the page header), you have a bug in the current switcher.

You can see it when you land on a website that uses themes and switcher and there is no local storage value auto stored yet (e.g. landing on a website for the first time).

If your OS is in the light mode, the switcher will show "Light mode" option as selected. If your OS is in the dark mode, switcher will show "Dark mode" option, when, instead, it should show "auto", since "auto" means "whatever is selected in the OS".