feat(core): add scenario scope to surfnet_exportSnapshot RPC#447
Open
MicaiahReid wants to merge 2 commits intomainfrom
Open
feat(core): add scenario scope to surfnet_exportSnapshot RPC#447MicaiahReid wants to merge 2 commits intomainfrom
surfnet_exportSnapshot RPC#447MicaiahReid wants to merge 2 commits intomainfrom
Conversation
surfnet_exportSnapshot RPC
…apshotResult enum
- change registerScenario to proactively evaluate account overrides for scenario - add new scope to exportSnapshot rpc to allow exporting a scenario
7a7ae28 to
65fe700
Compare
Member
|
I'm confused, do we still need this PR @MicaiahReid ? |
Member
Author
Hmm, good question. This PR does a few potentially helpful things, if scenarios are to be more developed:
If we see scenarios being fleshed out further as a feature, this PR should probably be taken over the finish line. If not, we can probably close. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.