Skip to content

feat(core): add scenario scope to surfnet_exportSnapshot RPC#447

Open
MicaiahReid wants to merge 2 commits intomainfrom
scenario-export
Open

feat(core): add scenario scope to surfnet_exportSnapshot RPC#447
MicaiahReid wants to merge 2 commits intomainfrom
scenario-export

Conversation

@MicaiahReid
Copy link
Member

@MicaiahReid MicaiahReid commented Dec 13, 2025

  • change registerScenario to proactively evaluate account overrides for scenario
  • add new scope to exportSnapshot rpc to allow exporting a scenario

@MicaiahReid MicaiahReid changed the title Scenario export feat(core): add scenario snapshot export Dec 13, 2025
@MicaiahReid MicaiahReid changed the title feat(core): add scenario snapshot export feat(core): add scenario scope to surfnet_exportSnapshot RPC Dec 13, 2025
@MicaiahReid MicaiahReid requested a review from lgalabru December 13, 2025 07:40
 - change registerScenario to proactively evaluate account overrides for scenario
 - add new scope to exportSnapshot rpc to allow exporting a scenario
@lgalabru
Copy link
Member

lgalabru commented Feb 5, 2026

I'm confused, do we still need this PR @MicaiahReid ?

@MicaiahReid
Copy link
Member Author

I'm confused, do we still need this PR @MicaiahReid ?

Hmm, good question.

This PR does a few potentially helpful things, if scenarios are to be more developed:

  • proactively compiles all account changes for a scenario rather than lazily
    • so, when you register the scenario, it fetches all accounts, and generates the new account states and stores that
    • when you step through slots it's just applying the already computed account state, rather than fetching accounts and computing on the fly
  • allows exporting those scenario account states as a snapshot, to be imported for tests

If we see scenarios being fleshed out further as a feature, this PR should probably be taken over the finish line. If not, we can probably close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants