Skip to content

Avoid unnecessary allocation in Uncancelable trait. #4600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nmichael44 wants to merge 1 commit into
base: series/3.x
Choose a base branch
from
+6 −6
Open

Avoid unnecessary allocation in Uncancelable trait. #4600

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions kernel/shared/src/main/scala/cats/effect/kernel/MonadCancel.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

package cats.effect.kernel

import cats.{MonadError, Monoid, Semigroup}
import cats.{Id, MonadError, Monoid, Semigroup}
import cats.data.{
EitherT,
IndexedReaderWriterStateT,
Expand Down Expand Up @@ -602,11 +602,11 @@ object MonadCancel {
}
}

trait Uncancelable[F[_], E] { this: MonadCancel[F, E] =>
private val cachedIdPoll: Poll[Id] = new Poll[Id] {
def apply[A](fa: Id[A]): Id[A] = fa
}

private[this] val IdPoll = new Poll[F] {
def apply[A](fa: F[A]) = fa
}
trait Uncancelable[F[_], E] { this: MonadCancel[F, E] =>

def rootCancelScope: CancelScope = CancelScope.Uncancelable

Expand All @@ -618,7 +618,7 @@ object MonadCancel {
}

def uncancelable[A](body: Poll[F] => F[A]): F[A] =
body(IdPoll)
body(MonadCancel.cachedIdPoll.asInstanceOf[Poll[F]])
}

private[kernel] trait OptionTMonadCancel[F[_], E] extends MonadCancel[OptionT[F, *], E] {
Expand Down
Loading