add toggle to pause updates in the background#72
add toggle to pause updates in the background#72cjdunn wants to merge 9 commits intotypemytype:masterfrom
Conversation
|
–Just tried this and found out that even running a script to addAnchors runs much faster now, almost runs instantly, with the Pause Updates box checked : ) |
|
I renamed to "Pause Observer" to avoid confusion. And I changed the unpause behavior so the window doesnʻt scroll back up to top of window, this was getting annoying |
- use the checkbox label itself - set a live updating flag and use it to reload on a font changes - save it in the defaults
|
good plan! only the code is really way to complex for what it should do :) |
typemytype
left a comment
typemytype
left a comment
There was a problem hiding this comment.
can you give me write access, so I can push my changes to your PR
| yPos = -20 | ||
| checkBoxSize = 18 | ||
| self.w.pauseOnOff = CheckBox((leftMargin, yPos, checkBoxSize, checkBoxSize), "", sizeStyle="small", callback=self.pause) | ||
| self.w.pauseLabel = TextBox((checkBoxSize+5, yPos+2, -leftMargin, checkBoxSize), "Pause Observer", sizeStyle="small") |
There was a problem hiding this comment.
why a label? use CheckBox(posSize, "Live Updates")
| self.font = None | ||
|
|
||
|
|
||
| def pause(self, sender): |
There was a problem hiding this comment.
this should just set a flag based on the sender.get()
There was a problem hiding this comment.
and use the flag in the fontChanged callback to reload or not
|
could you test these changes? implemented without fiddling around with pauseFonts + renamed it to "Live Updating" |
|
Thank you!! I’ll give it a try
…On Fri, Apr 7, 2023 at 8:02 AM Frederik Berlaen ***@***.***> wrote:
could you test these changes?
implemented without fiddling around with pauseFonts + renamed it to "Live
Updating"
—
Reply to this email directly, view it on GitHub
<#72 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA5YGUP2SSMYFVJL6JJAUYLW7765FANCNFSM6AAAAAAWVVZFWY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
–Overall looks great, very happy with this! Thanks so much! |
|
a complete reload when the window becomes active is a good plan! |
|
Awesome! That update matches the behavior I expected. LGTM! |
|
why did you close it? |
2 participants
–Without pausing updates, RF becomes super slow if I want to temporarily work on a glyph without closing this window.
–Many times updating a glyph is necessary in the middle of accent building, and I donʻt want to have to always close the GlyphBuilder window and loose my place.
–Pausing updates makes it possible to switch to drawing a glyph for a while, or even switch to another typeface for a while, without RF becoming so slow itʻs unusable.
–Iʻm sure my code can be improved, and fixes are welcome! Perhaps the checkbox state becomes a preference setting that is saved for next time you open GlyphBuilder (word-o-mat does something like this)? Personally, I would leave this checked maybe 90% of the time.
Thanks @typemytype for considering the PR!