fix: only require at least 1 field to be present in a collection update#107
Open
jackwilsdon wants to merge 1 commit intotypesense:masterfrom
Open
fix: only require at least 1 field to be present in a collection update#107jackwilsdon wants to merge 1 commit intotypesense:masterfrom
jackwilsdon wants to merge 1 commit intotypesense:masterfrom
Conversation
jackwilsdon
force-pushed
the
collection-update-optional-fields
branch
from
8a1513d to
9f9114c
Compare
…pdate The collection update endpoint only requires that at least one property is present - "fields" is not strictly required (e.g. for metadata updates).
jackwilsdon
force-pushed
the
collection-update-optional-fields
branch
from
9f9114c to
2acd9a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
The collection update endpoint only requires that at least one property is present - "fields" is not strictly required (e.g. when doing metadata updates).
https://github.com/typesense/typesense/blob/1c5804194175210b3fbdd4972ba3cff2bbdf85cf/src/core_api.cpp#L301-L367
PR Checklist