Draft
Conversation
Author
|
Looks like this doesn't work for object fields, as they have two levels of nested objects: {
"highlight": {
"my_object_field": {
"my_matching_key_1": {
"matched_tokens": [ "SEARCH TERM" ],
"snippet": [ "<mark>SEARCH TERM</mark>" ]
},
"my_matching_key_2": {
"matched_tokens": [ "SEARCH TERM" ],
"snippet": [ "<mark>SEARCH TERM</mark>" ]
}
}
}
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
This PR introduces a new
SearchHighlightV2type which is used for theSearchResultHit#highlightfield.I've opened this as a draft as this version of the spec doesn't quite play nicely with the generator used by
typesense-go(it creates some weirdly named structs). The generated Go version can be a bit nicer by making these changes:Annoyingly, the Go version still doesn't offer a way to detect if the
oneOfis an array or not, instead throwing an error if you call the wrongAsSearchHighlightV2*function.But introducing an additional schema seems less than ideal. I'm open to any suggestions on how to improve this further.
PR Checklist