Skip to content

Conversation

@PleBea
Copy link

@PleBea PleBea commented Nov 30, 2025

Description

Updated the IsUUID tests to align with the updated JSDoc, which specifies support for all UUID versions (1-8, nil, max, all).

Previously, the tests primarily covered versions 3, 4, and 5. I have added test cases to verify that the IsUUID decorator correctly validates all UUID specifications supported by the underlying validator.js library, including versions 1, 2, 6, 7, 8, nil, and max.

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated
  • I have run the project locally and verified that there are no errors

Fixes

fixes #2581
fixed #2648

@WikiRik
Copy link

WikiRik commented Dec 5, 2025

Maybe #2648 can also be fixed with this PR? Since it's the same validator that requires an update

@PleBea
Copy link
Author

PleBea commented Dec 5, 2025

Maybe #2648 can also be fixed with this PR? Since it's the same validator that requires an update

Yes, that's correct. This PR now specifically addresses issue #2648 as well.

I've made a small adjustment/tweak to the relevant code (the validator) to ensure it correctly fixes #2648. Once this PR is merged, we can close that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

fix: isUUID validation fails for UUID like strings feature: 🔍 Add support for UUID v7 in IsUUID validator

2 participants