fix: suppress unintended tag switch from macOS auto-activation after app termination#161
Merged
fix: suppress unintended tag switch from macOS auto-activation after app termination#161
Conversation
…app termination When apps are terminated in quick succession (e.g., repeated Cmd-Q), macOS auto-activates another app which may have hidden windows on a different tag, causing an unwanted tag switch. The existing deferred logic (same-batch WindowDestroyed detection) cannot handle this because the AppTerminated event arrives in a later batch (~60ms delay). Add last_app_terminated_at timestamp to RunLoopContext. When a deferred tag switch decision finds the window still alive but an app was terminated within the last 2 seconds, suppress the tag switch and restore focus to the current display's visible window instead.
Rename last_app_terminated_at to last_focused_window_destroyed_at and set the timestamp when the focused window is destroyed (not just on AppTerminated). This covers Cmd-W closing the last window of an app and batch-separated events where workspace callback hasn't fired yet. Also narrow the timestamp scope to only fire when focus is actually lost, preventing false suppression after background app termination.
typester
force-pushed
the
fix/auto-tag-change
branch
from
9f63a37 to
f52b549
Compare
macOS can take over 500ms to redirect Firefox focus to a different window on another display after activate_application. The previous 500ms suppression window was insufficient, causing spurious tag switches when auto-raise focused Firefox on a secondary display. Also add debug logging to find_window_at_point and auto-raise no-window branch to aid future diagnosis.
Merged
typester
pushed a commit
that referenced
this pull request
Apr 13, 2026
## 🤖 New release * `yashiki-ipc`: 0.12.0 -> 0.12.1 * `yashiki`: 0.12.0 -> 0.12.1 * `yashiki-layout-tatami`: 0.12.0 -> 0.12.1 * `yashiki-layout-byobu`: 0.12.0 -> 0.12.1 <details><summary><i><b>Changelog</b></i></summary><p> ## `yashiki-ipc` <blockquote> ## [0.12.0](yashiki-ipc-v0.11.6...yashiki-ipc-v0.12.0) - 2026-02-25 ### Added - [**breaking**] add keybinding mode system (river-style) ([#157](#157)) </blockquote> ## `yashiki` <blockquote> ## [0.12.1](yashiki-v0.12.0...yashiki-v0.12.1) - 2026-04-13 ### Fixed - suppress cross-PID spurious focus bounce on tag switch ([#165](#165)) - suppress unintended tag switch from macOS auto-activation after app termination ([#161](#161)) </blockquote> ## `yashiki-layout-tatami` <blockquote> ## [0.7.3](yashiki-layout-tatami-v0.7.2...yashiki-layout-tatami-v0.7.3) - 2026-01-20 ### Other - update Cargo.lock dependencies </blockquote> ## `yashiki-layout-byobu` <blockquote> ## [0.7.3](yashiki-layout-byobu-v0.7.2...yashiki-layout-byobu-v0.7.3) - 2026-01-20 ### Other - update Cargo.lock dependencies </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When apps are terminated in quick succession (e.g., repeated Cmd-Q), macOS auto-activates another app which may have hidden windows on a different tag, causing an unwanted tag switch. The existing deferred logic (same-batch WindowDestroyed detection) cannot handle this because the AppTerminated event arrives in a later batch (~60ms delay).
Add last_app_terminated_at timestamp to RunLoopContext. When a deferred tag switch decision finds the window still alive but an app was terminated within the last 2 seconds, suppress the tag switch and restore focus to the current display's visible window instead.