Conversation
elegaanz
left a comment
There was a problem hiding this comment.
Thank you for this package :) A few remarks:
| @@ -0,0 +1,11 @@ | |||
| [package] | |||
| name = "verovio" | |||
There was a problem hiding this comment.
Since this is not an official port of Verovio for Typst, can you pick another name please? It can still make a reference to the original library, but it should be clear that it is not affiliated with it.
There was a problem hiding this comment.
Okay gonna rename to scoryst (score, typst, choriste mashup)
| repository = "https://github.com/bernsteining/verovio" | ||
| keywords = ["music", "notation", "score", "scoring", "partition", "tablature", "engraving", "verovio", "abc", "musicxml", "mei", "humdrum"] | ||
| categories = ["visualization"] | ||
| compiler = "0.14.2" |
There was a problem hiding this comment.
This corresponds to the earliest supported Typst version, so unless you depend on a patch introduced in 0.14.2 this can be at least 0.14.0. It may even be lower depending on what features you are actually using. By picking the latest version, people who didn't update (or can't update) won't be able to import your package, even if it may work fine in practice.
There was a problem hiding this comment.
I would suggest people to update to the latest version ? Especially in the changelog it's suggested that people update 0.14.{0,1} to 0.14.2 (cf https://typst.app/docs/changelog/0.14.2/), so let's stick with 0.14.2 nah ?
There was a problem hiding this comment.
Yes, of course it is always better to be on the very last patch version, but people may depend on their distribution package manager and may not be able to use the very last version, especially if it was released recently. They may also need some older packages that are no longer working with more recent Typst versions. So having a bit more flexibility by not requiring the very last version is better.
There was a problem hiding this comment.
Then should I find the lowest version for which my plugin works ?
There was a problem hiding this comment.
Ideally, yes. You can use the changelogs to see what breaking changes each version brings and when specific features were introduced. But since this is quite a lot of work to properly do, changing the limit to 0.14.0 is also a good compromise: most people should be using the 0.14 series, and it's unlikely that one of the patches in 0.14.1 or 0.14.2 broke your package.
|
|
||
| Returns the number of pages for the given music data. | ||
|
|
||
| ## Building |
There was a problem hiding this comment.
This section is not really relevant to people browsing Typst Universe. I would suggest to remove it from this copy of the README. This not a blocker, and if you think it might still be useful or if you don't want to maintain two versions of the README, it is also perfectly fine to keep it.
|
I've been trying to compile MuseScore to Wasm to embed it into Typst without success for a while. I knew about Verovio but didn't look into it that much. Very impressive that you managed to do it! I will definitely look into it when I have more time! |
Thanks! I tried to compile Verovio for Typst several times in August without success but then managed to achieve it recently, lots of shenanigans. If you find bugs or have speedup ideas tell me :) |
|
Thank you! |
I am submitting
Description:
A Typst plugin that allows music engraving in Typst from multiple formats using Verovio, thanks to WASM.
Features
Check the documentation for a full demonstration with examples.
I have read and followed the submission guidelines and, in particular, I
typst.tomlfile with all required keysREADME.mdwith documentation for my packageLICENSEfile or linked one in myREADME.mdexcluded PDFs or README images, if any, but not the LICENSE