This repository was archived by the owner on Jan 28, 2025. It is now read-only.
Open
Conversation
Contributor
skhanker
commented
Aug 8, 2014
skhanker
commented
- removed iframes from auth and index
- added iframe to get and view
- added js to clean up iframes
- moved javascript source to live on library side of code so that we can alter js without re-generating BB
…me no longer has iFrame. add basic style to iFrame to not have to do it with JS later
- Removed iFrame from get.jsp and view.jsp (understanding now is that they will handoff to auth.jsp or index.jsp, which retain iFrame) - Removed associated javascript for iFrames that were removed Added Style Change: - Targetied the parent div of the resultant iFrame that gets injected and removed margin, since we can re-add within the iFrame as needed to retain the L&F of LOCR.
…me no longer has iFrame. add basic style to iFrame to not have to do it with JS later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.