Conversation
3v1n0
force-pushed
the
gnome-44-support
branch
from
57cdae6 to
4066e72
Compare
|
From what I can tell So https://github.com/Leleat/Tiling-Assistant/blob/main/tiling-assistant%40leleat-on-github/src/extension/moveHandler.js#L489 also needs an update. Rest looks good and from quick testing (in a VM) it works well. PS. Officially (a.k.a. according to the README) I only support the latest Shell version. In the past I occasionally supported multiple versions, if the the compatibility code wasn't too big. So feel free to drop 43 support, if you want. Ofc you can also leave it as is, up to you. |
|
I've encountered a crash when testing on GNOME 44 (Fedora Rawhide). It might be related to the new grab mechanic. I haven't looked it deeply yet so I can't tell if it's an issue with T-A, mutter, or g-s. STR with a (near?) 100% success rate:
|
Good catch! Changed that too.
Well, changes were minor enough to be able to support both versions without many efforts I think. |
Mh, I've not been able to reproduce that, but I may need to check it further. |
I was able to reproduce the crash with the normal app switcher as well. So I've opened https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/6491. Since the crash isn't T-A's fault (probably), I think this is good to go once you've rebased. |
|
Okay, one more thing: |
Yeah, i noticed that too... I've fixed it. |
I've moved it to mutter, but personally I can't reproduce it in 44.rc at least... :( |
tiling-assistant@leleat-on-github/src/extension/activeWindowHint.js
Outdated
Show resolved
Hide resolved
Hmm, so either it's a GNOME bug or it's specific to my setup. Either way, it's not T-A issue so whatever I guess. Only found 2 remaining issues (or 1 issue and 1 nit). After you've fixed them, feel free to merge this. Thanks for the PR! |
GNOME Shell 44 includes new Clutter Grabs, so we don't have to manually perform the grab-end/grab-begin actions when the user tries to untile a window by ungrabbing it. We can just resize the window and start monitor for move events again.
Do not unconditionally reset the user settings, as these could be different, instead save the user set old value and restore it if that's the case, or restore the setting otherwise
…available These have been removed in GNOME 44, so we need to check if they're available before trying to get any value from it.
As other idles events these should be cancelled when destroyed.
We can just cancel it every time we require to hide the actor and stop any eventual show later set in case
It can be used to add and remove laters in both 44 and 43.
|
Thanks! |
|
@Leleat This change looks great on Fedora 38 beta with GNOME 44.rc. 👏 |
|
Hey @Leleat, any idea on when the next extension's release would be available? Thanks 🙏 |
|
@GuillaumeAmat I'll make a new release after #244. |
|
Thanks for the heads-up 🙏 |
4 participants
GNOME removed grab op's manual handling support, but we can avoid them by just adapting the motion.
Tested in both wayland and X11, while I didn't test if older versions could still work using the same codepath (yet).