Conversation
Collaborator
Leleat
commented
Jan 12, 2026
Leleat
commented
- fix: move Meta.is_wayland_compositor from common.js to utility.js
- fix: make Tiling Popup work with mouse again (v2)
d111a33 fixed the related issue for 49 by syncing the src/dependencies/unexported/{altTab,switcherPopup}.js with the upstream changes. But this broke the Tiling Popup for GNOME 48. So let's fix this with the most simple way: Copy the old version of the files in and conditionally use them. Related: #419
230559 created a `is_wayland_compositor` check in common.js since mutter removed it in 50. This broke the prefs window since the file imported gi://Meta, which only exists in the Shell process but common.js is used for both the (shell) extension and prefs. So move the function to utility.js, which is intended only for shell usage. Fixes: 230559b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.