Perform final parse after termination trigger set #192
+5
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
If there is a long running callback, and the final lines of a results file are written while the callback is being executed and the termination trigger is called, then when the callback finishes it will stop the thread loop and never parse these final lines.
This change makes it so that after the termination trigger is set, the thread does one final loop to check for any final lines in the file, before exiting.
Hopefully will fix #155
✅ Checks
docswhere appropriate.