-
Notifications
You must be signed in to change notification settings - Fork 17
Quick resistive tf fixes #4014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Quick resistive tf fixes #4014
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4014 +/- ##
==========================================
- Coverage 46.30% 45.85% -0.45%
==========================================
Files 123 123
Lines 28961 29396 +435
==========================================
+ Hits 13411 13481 +70
- Misses 15550 15915 +365 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1f7e585 to
db27934
Compare
j-a-foster
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with changes.
| }, | ||
| ) | ||
|
|
||
| # Add info about the Winding Pack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function is way way too long. Instead of adding to it please refactor it
…outtf call in ResistiveTFCoil
…t temperature in iteration variables
db27934 to
c5bebef
Compare
This pull request introduces a comprehensive renaming and standardization of variable names related to the TF coil cooling system throughout the codebase and documentation. The changes improve clarity and consistency, making it easier to understand and maintain the code. Additionally, some minor updates were made to plots and documentation to reflect these changes and provide more detailed information.
Variable Renaming and Standardization
Renamed TF coil cooling variables for clarity and consistency:
tcoolin→temp_cp_coolant_inletrcool→radius_cp_coolant_channelvcool→vel_cp_coolant_midplanencool→n_cp_coolant_channels_totaldtiocool→dtemp_cp_coolantUpdated all input files and process logic to use new variable names, ensuring backward compatibility via the obsolete variable mapping.
Documentation Improvements
dtemp_prefix for relative temperature rises or falls.Plot and Visualization Enhancements
Minor Additions
m_tf_wp_steel_conduitintfcoil_variables.py.## DescriptionChecklist
I confirm that I have completed the following checks: