-
Notifications
You must be signed in to change notification settings - Fork 17
c_tf_turn error catching #4034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
c_tf_turn error catching #4034
Conversation
…and icc 77 used simultaneously
bc6e1d4 to
4f18154
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4034 +/- ##
==========================================
- Coverage 45.88% 41.83% -4.05%
==========================================
Files 123 123
Lines 29087 40980 +11893
==========================================
+ Hits 13346 17144 +3798
- Misses 15741 23836 +8095 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
process/init.py
Outdated
| data_structure.numerics.icc[: data_structure.numerics.nvar] == 77 | ||
| ).any(): | ||
| raise ProcessValidationError( | ||
| "Cannot use iteration variable 60 and constraint 77 simultaneously" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest this has more information e.g.
Cannot use iteration variable 60 (TF coil current per turn,
c_tf_turn) and constraint 77 (maximum TF current per turn) simultaneously.
process/init.py
Outdated
| data_structure.numerics.ixc[: data_structure.numerics.nvar] == 60 | ||
| ).any() and data_structure.tfcoil_variables.i_tf_turns_integer == 1: | ||
| raise ProcessValidationError( | ||
| "Iteration variable 60 (c_tf_turn) cannot be used when i_tf_turns_integer == 1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe something like this for more useful information.
Iteration variable 60 (TF current per turn,
c_tf_turn) cannot be used with the TF coil integer turn model (i_tf_turns_integer == 1) as it is a calculated output instead for this model. However, the maximum current per turn can be constrained with constraint 77.
Description
Check that ixc = 60 (c_tf_turn) is not used when i_tf_turns_integer is 1
Check that ixc = 60 is not used with icc = 77
Updated version of #3114 - this PR was very outdated. Will close #724
Checklist
I confirm that I have completed the following checks: