Skip to content

Preserve fixed retry delay in links workflow#298

Merged
glenn-jocher merged 1 commit into
mainfrom
retry-fixed-backoff
Apr 17, 2026
Merged

Preserve fixed retry delay in links workflow#298
glenn-jocher merged 1 commit into
mainfrom
retry-fixed-backoff

Conversation

@glenn-jocher
Copy link
Copy Markdown
Member

@glenn-jocher glenn-jocher commented Apr 17, 2026

Summary

Preserves the previous fixed 30-minute retry spacing in the links workflow after ultralytics/actions/retry switched to exponential backoff with jitter by default.

Changes

  • add backoff: fixed to the retry-wrapped download step in .github/workflows/links.yml

Why

Without an explicit override, the second and third retries can expand beyond the intended 30-minute spacing.

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

🛠️ This PR updates the link-checking GitHub Actions workflow to use a fixed retry backoff, making documentation link checks more predictable and stable.

📊 Key Changes

  • Added backoff: fixed to the .github/workflows/links.yml workflow.
  • This change affects the retry behavior for the link-checking job when it encounters failures.
  • The workflow still keeps the existing retry count and delay settings, but now retries happen with a consistent interval instead of a varying backoff pattern.

🎯 Purpose & Impact

  • Improves reliability of automated link validation for the ultralytics/docs repository 🔗
  • Makes retry timing more predictable, which can help when failures are caused by temporary external issues like slow websites or network hiccups ⏱️
  • May reduce unexpected delays in CI runs and make troubleshooting easier for maintainers 🧪
  • Helps keep documentation quality high by ensuring broken-link checks run more consistently 📚

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 17, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment Apr 17, 2026 11:17am

Request Review

@UltralyticsAssistant UltralyticsAssistant added bug Something isn't working devops GitHub Devops or MLops fixed Bug has been resolved labels Apr 17, 2026
@UltralyticsAssistant
Copy link
Copy Markdown
Member

👋 Hello @glenn-jocher, thank you for submitting a ultralytics/docs 🚀 PR! This is an automated message to help streamline review, and an engineer will assist you soon 😊 Please review the checklist below to help ensure smooth integration:

  • Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions.
  • Synchronize with Source: Confirm your PR is synchronized with the ultralytics/docs main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • Ensure CI Checks Pass: Verify all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please address the issues.
  • Update Documentation: Update the relevant documentation for any new or modified features.
  • Add Tests: If applicable, include or update tests to cover your changes, and confirm that all tests are passing.
  • Sign the CLA: Please ensure you have signed our Contributor License Agreement if this is your first Ultralytics PR by writing "I have read the CLA Document and I sign the CLA" in a new message.
  • Minimize Changes: Limit your changes to the minimum necessary for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee

For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀

Copy link
Copy Markdown
Member

@UltralyticsAssistant UltralyticsAssistant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 PR Review

Made with ❤️ by Ultralytics Actions

Clean change. Adding backoff: fixed is consistent with the stated goal of preserving a constant retry interval, and there are no clear bugs or maintainability issues visible in this diff.

@glenn-jocher glenn-jocher merged commit bb2a49a into main Apr 17, 2026
4 checks passed
@glenn-jocher glenn-jocher deleted the retry-fixed-backoff branch April 17, 2026 11:20
@UltralyticsAssistant
Copy link
Copy Markdown
Member

🎉 Huge thanks for merging this, @glenn-jocher!

This is a small change with a meaningful impact—making link-check retries use a fixed backoff brings more predictability and stability to CI, which helps keep the Ultralytics docs workflow reliable and easier to troubleshoot. As Benjamin Franklin said, “An ounce of prevention is worth a pound of cure.” This update is a great example of that mindset in action: a thoughtful refinement that helps prevent flaky checks and supports consistently high documentation quality.

Really appreciate the care you put into these infrastructure improvements—they make a difference for everyone contributing to and relying on the docs. 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working devops GitHub Devops or MLops fixed Bug has been resolved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants