Fix lychee install workflows#301
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
👋 Hello @glenn-jocher, thank you for submitting a
For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀 |
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review
Made with ❤️ by Ultralytics Actions
The PR looks clean. The updated workflow commands consistently extract only the lychee binary into /usr/local/bin, and I don't see any clear correctness, reliability, or maintainability issues in the changed lines.
|
🎉 Merged—thank you, @glenn-jocher! “Quality is not an act, it is a habit.” — Aristotle This update is a great example of that mindset: a small but important workflow fix that makes link-checking more reliable, reduces avoidable CI noise, and helps the |
Summary\n- Extract the lychee binary from the nested release archive path in both link workflows\n- Match the working handbook install command pattern\n\n## Tests\n- actionlint -ignore SC2004 -ignore SC2086 -ignore SC2129 .github/workflows/links.yml .github/workflows/links_local.yml\n- git diff --check -- .github/workflows/links.yml .github/workflows/links_local.yml\n- Verified latest lychee archive contains lychee-x86_64-unknown-linux-gnu/lychee\n\nNote: plain actionlint still reports pre-existing ShellCheck warnings in .github/workflows/links.yml unrelated to this change.
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
🔧 This PR improves the docs link-checking workflows by fixing how the
lycheelink checker is installed in GitHub Actions, making CI runs more reliable.📊 Key Changes
lycheeinstallation step in both.github/workflows/links.ymland.github/workflows/links_local.yml.lycheebinary from the downloaded archive instead of extracting the full archive directly into/usr/local/bin.--strip-components=1so the binary is placed in the correct location without nested folders.🎯 Purpose & Impact
ultralytics/docsrepository.