Skip to content

Conversation

@busrasengul
Copy link
Contributor

@busrasengul busrasengul commented Dec 3, 2025

πŸ“‹ Description

Updating Customizing, Property Editor

πŸ“Ž Related Issues (if applicable)

βœ… Contributor Checklist

I've followed the Umbraco Documentation Style Guide and can confirm that:

  • [ x ] Sentences are short and clear (preferably under 25 words).
  • [ x ] Passive voice and first-person language (β€œwe”, β€œI”) are avoided.
  • [ x ] Relevant pages are linked.
  • [ x ] All links work and point to the correct resources.
  • [ x ] Typos, broken links, and broken images are fixed.

Product & Version (if relevant)

v17, v16

Issue #7688

@busrasengul busrasengul marked this pull request as ready for review December 3, 2025 09:41
@Luuk1983
Copy link
Contributor

Luuk1983 commented Dec 3, 2025

The order of the menu items is different than what's on your page:

image

Consider streamlining this. I think both your document and the menu should be ordered by what is the most logical flow when you want to learn about Property Editors.

Copy link
Contributor

@Luuk1983 Luuk1983 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@leekelleher leekelleher self-requested a review December 15, 2025 09:19
Copy link
Member

@leekelleher leekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with the updates from a technical perspective. Excellent work! πŸš€

Updated the README.md to improve clarity and consistency in the links and descriptions for Property Editors.
Copy link
Contributor

@sofietoft sofietoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great @busrasengul πŸ‘

I've made a single comment - let me know what you think!


{% hint style="info" %}
[This tutorial](../../tutorials/creating-a-property-editor/) contains step-by-step instructions for building a custom Property editor.
[This tutorial](../../tutorials/creating-a-property-editor/) contains step-by-step instructions for building a custom Property Editor.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a little unclear as to what "This" what referring to, so I've rewritten this note a bit.
Let me know what you think!

Suggested change
[This tutorial](../../tutorials/creating-a-property-editor/) contains step-by-step instructions for building a custom Property Editor.
This article acts as an overview for all things related to Property Editors. See the [Creating a Property Editor](../../tutorials/creating-a-property-editor/) section for step-by-step instructions on building a custom Property Editor.

## [Property Actions](property-actions.md)

Use Property Actions to add additional functionality to your custom property editors.
Use Property Actions to add additional functionality to your custom Property Editors, such as custom buttons or actions that appear alongside the editor in the backoffice.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing a too-long sentence:

Suggested change
Use Property Actions to add additional functionality to your custom Property Editors, such as custom buttons or actions that appear alongside the editor in the backoffice.
Use Property Actions to add additional functionality to your custom Property Editors. This could include custom buttons or actions that appear alongside the editor in the backoffice.

Copy link
Contributor

@sofietoft sofietoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple more comments on too-long sentences.

A Property Editor is composed of two key extensions: [Property Editor Schema](composition/property-editor-schema.md) and [Property Editor UI](composition/property-editor-ui.md). These components work together to define the data structure and user interface for content entry in the Umbraco backoffice.

Reference for the package.manifest JSON file format to register one or more property editors for Umbraco.
Optionally, you can use a [Property Editor Data Source](composition/property-editor-data-source.md) to provide data to your Property Editor UI, allowing the same UI to work with different data sources.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Optionally, you can use a [Property Editor Data Source](composition/property-editor-data-source.md) to provide data to your Property Editor UI, allowing the same UI to work with different data sources.
Optionally, you can use a [Property Editor Data Source](composition/property-editor-data-source.md) to provide data to your Property Editor UI. This will allow the same UI to work with different data sources.

## [Property Actions](property-actions.md)

Use Property Actions to add additional functionality to your custom property editors.
Use Property Actions to add additional functionality to your custom Property Editors, such as custom buttons or actions that appear alongside the editor in the backoffice.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Use Property Actions to add additional functionality to your custom Property Editors, such as custom buttons or actions that appear alongside the editor in the backoffice.
Use Property Actions to add additional functionality to your custom Property Editors. This could include custom buttons or actions that appear alongside the editor in the backoffice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants