Feat/add to group dataframe() function#3000
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3000 +/- ##
==========================================
- Coverage 95.64% 95.58% -0.07%
==========================================
Files 156 156
Lines 16946 16997 +51
==========================================
+ Hits 16208 16246 +38
- Misses 738 751 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
thanks for this PR @Jaco-Pastorius, it looks very nice! I added some suggestions regarding handling of stochastic timeseries, and some personal nitpicks (forgive me pls) but it looks good, let me know what you think
|
Hey @jakubchlapek, thanks a lot for your review it all makes sense to me ! I've also added some tests in my latest commit as some lines weren't covered. I also added an argument in Cheers |
There was a problem hiding this comment.
Hey @Jaco-Pastorius , two very small clarifications, i've commited them so you don't have to, but besides that it LGTM, unless @dennisbader has any nitpicks haha. Thanks for this PR, I think the add_group_col is very neat, cool idea :)
Cheers
dennisbader
left a comment
There was a problem hiding this comment.
Thanks a lot @Jaco-Pastorius for another great PR 🥳 🚀
It simplifies things quite a lot for the user that now we handle this under the hood 💯
I pushed some minor changes, main differences:
- changed the column naming for output component-specific static covaraites to "{static_cov_column}_{series_column}"
- added some unit tests for
to_dataframe() - some docs rephrasing
I'll merge once all tests have passed 🚀
Checklist before merging this PR:
Fixes #2965.
Summary
to_group_dataframe()function that takes a list of series as an input and returns a long format dataframe.TimeSeries.to_dataframe()method. Those can be added as columns in the result dataframe.TimeSeries.to_dataframe()method control the addition of metadata and static covariates.to_group_dataframe()andTimeSeries.to_dataframe()Other Information
A new feature request should be added to add component level static covariate in
from_group_dataframe()