Conversation
olxmpe
requested review from
OwenCoogan,
aprentout and
nathalieArnoux
and removed request for
a team
Elodie-DeMatteis-Upf
left a comment
Elodie-DeMatteis-Upf
left a comment
There was a problem hiding this comment.
Some nit comments and questions, great job!
| return this._lookupComponent(columnDef, 'header'); | ||
| } | ||
|
|
||
| private _lookupComponent( |
There was a problem hiding this comment.
I think _ for private functions is a javascript habit no? I guess you could remove it here
There was a problem hiding this comment.
It's to differentiate this function from the one it calls (super.lookupComponent)
|
|
||
| #### Faceted Filtering | ||
|
|
||
| Hypertable provides built-in support for **faceted filtering**, allowing users to select multiple values for a column filter from a dynamic list of facets. |
There was a problem hiding this comment.
It may be a dumb question, but what does "faceted" mean in this context?
There was a problem hiding this comment.
The normal filters are the ones like with value / without value:
The 'faceted' ones are the ones that need a list of values:
| - Fetches facets when the filter UI opens | ||
| - Displays a skeleton loader while loading | ||
| - Supports search with a 300 ms debounce | ||
| - Allows multiple facet selection | ||
| - Sorts facets by `count` descending by default (custom sorting function can be provided) |
There was a problem hiding this comment.
Same here, dumb question but what is a "facet"? ^^'
There was a problem hiding this comment.
and facets are the elements in the list 🙂
upfluence-bot
added
reviewed/ready-to-merge
reviewed/needs-work
and removed
reviewed/ready-to-merge
labels
upfluence-bot
added
reviewed/needs-review
reviewed/needs-work
and removed
reviewed/needs-work
reviewed/needs-review
labels
6 participants
What does this PR do?
Related to : #
What are the observable changes?
🧑💻 Developer Heads Up
⚡ Since we are using Ember Octane now:
Useful Resource : Ember Octane vs Classic Cheat Sheet
Good PR checklist
Additional Notes