Skip to content

refactor: use resolve for paths#176

Merged
olivermrose merged 2 commits intomainfrom
refactor/route-resolve
Jan 20, 2026
Merged

refactor: use resolve for paths#176
olivermrose merged 2 commits intomainfrom
refactor/route-resolve

Conversation

@olivermrose
Copy link
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings January 20, 2026 18:06
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors path handling throughout the application to use SvelteKit's resolve function from $app/paths, ensuring proper path resolution that respects any configured base path.

Changes:

  • Added resolve imports from $app/paths across 15 files
  • Converted all hardcoded navigation paths to use resolve() for both goto() calls and href attributes
  • Parameterized routes now use SvelteKit's route ID pattern with proper parameter interpolation

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/routes/settings/+page.svelte Converted logout button navigation to use resolve()
src/routes/auth/logout/+page.svelte Converted login redirect to use resolve()
src/routes/auth/login/+page.svelte Converted home page redirect to use resolve()
src/routes/(main)/whispers/+page.svelte Converted whisper detail link to use parameterized resolve()
src/routes/(main)/channels/split/SplitHeader.svelte Converted channel navigation and home redirect to use resolve()
src/routes/(main)/channels/+layout.svelte Converted home redirect to use resolve()
src/routes/(main)/+page.svelte Converted split view and channel navigation to use resolve()
src/routes/(main)/+layout.svelte Converted settings navigation to use resolve()
src/lib/split-layout.ts Converted split view activation to use resolve()
src/lib/menus/channel-menu.ts Converted channel join, leave, and split navigation to use resolve()
src/lib/components/TitleBar.svelte Converted settings and user channel navigation to use resolve()
src/lib/components/StreamTooltip.svelte Converted channel link to use parameterized resolve()
src/lib/components/Sidebar.svelte Converted whispers and split view navigation to use resolve()
src/lib/components/JoinDialog.svelte Converted channel join navigation to use parameterized resolve()
src/lib/commands/built-in/leave.ts Converted home redirect to use resolve()
src/lib/commands/built-in/join.ts Converted channel join navigation to use parameterized resolve()

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@olivermrose olivermrose merged commit bc7b63f into main Jan 20, 2026
1 of 2 checks passed
@olivermrose olivermrose deleted the refactor/route-resolve branch January 20, 2026 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants