Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors path handling throughout the application to use SvelteKit's resolve function from $app/paths, ensuring proper path resolution that respects any configured base path.
Changes:
- Added
resolveimports from$app/pathsacross 15 files - Converted all hardcoded navigation paths to use
resolve()for bothgoto()calls andhrefattributes - Parameterized routes now use SvelteKit's route ID pattern with proper parameter interpolation
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/routes/settings/+page.svelte |
Converted logout button navigation to use resolve() |
src/routes/auth/logout/+page.svelte |
Converted login redirect to use resolve() |
src/routes/auth/login/+page.svelte |
Converted home page redirect to use resolve() |
src/routes/(main)/whispers/+page.svelte |
Converted whisper detail link to use parameterized resolve() |
src/routes/(main)/channels/split/SplitHeader.svelte |
Converted channel navigation and home redirect to use resolve() |
src/routes/(main)/channels/+layout.svelte |
Converted home redirect to use resolve() |
src/routes/(main)/+page.svelte |
Converted split view and channel navigation to use resolve() |
src/routes/(main)/+layout.svelte |
Converted settings navigation to use resolve() |
src/lib/split-layout.ts |
Converted split view activation to use resolve() |
src/lib/menus/channel-menu.ts |
Converted channel join, leave, and split navigation to use resolve() |
src/lib/components/TitleBar.svelte |
Converted settings and user channel navigation to use resolve() |
src/lib/components/StreamTooltip.svelte |
Converted channel link to use parameterized resolve() |
src/lib/components/Sidebar.svelte |
Converted whispers and split view navigation to use resolve() |
src/lib/components/JoinDialog.svelte |
Converted channel join navigation to use parameterized resolve() |
src/lib/commands/built-in/leave.ts |
Converted home redirect to use resolve() |
src/lib/commands/built-in/join.ts |
Converted channel join navigation to use parameterized resolve() |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.