Unstructured cookbook#207
Conversation
|
|
There was a problem hiding this comment.
🚩 Other cookbook examples include test files; this one does not
The langchain cookbook has test_integration.py, haystack has test_live.py, and crewai has test_live.py. This PR's unstructured cookbook has no test file. The CONTRIBUTING.md states "If you've added code that should be tested, add tests." For a cookbook/example script this is somewhat subjective — the dspy cookbook also lacks a test file — but it is a deviation from the majority pattern. Consider adding at least a minimal integration/smoke test for consistency.
Was this helpful? React with 👍 or 👎 to provide feedback.
|
Hi @SIDDHAARTHAA , thank you very much for working on this pr. Were you able to resolve all the comments from ai ? also can you please record a short 1 min video demonstrating the demo of implementation. |
|
Hey @yatharthk2, thanks for checking out. I’m working on it. |
Pull Request Checklist
Please ensure that your PR meets the following requirements:
Description
Adds a focused Unstructured + Moss cookbook for parsing raw files, chunking extracted content, preserving metadata, and incrementally upserting chunks into a Moss index for semantic search.
The cookbook includes a runnable ingestion script, sample documents, environment template, and setup/usage documentation.
Validation performed:
python -m py_compile examples/cookbook/unstructured/ingest.pyFixes #203
Type of Change