Skip to content

Add Image Filename Length Validation for Profile, Banner, and News Article Uploads #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
betsyecastro wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Add Image Filename Length Validation for Profile, Banner, and News Article Uploads #220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
005490b
Add filename length validation rule for image uploads
betsyecastro May 15, 2026
5908297
Add image requirements tooltip for profile and banner images
betsyecastro May 15, 2026
ada2365
Add image uploads requirements to the News section
betsyecastro May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions app/Http/Requests/Concerns/HasImageUploads.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,21 @@

namespace App\Http\Requests\Concerns;

use App\Rules\FilenameLengthRule;

trait HasImageUploads
{
public function uploadedImageRules(): string
public function uploadedImageRules(): array
{
$max_filesize = $this->maxFilesize() * 1000;
$allowed_mimes = implode(',', $this->supportedMimes());

return "mimes:$allowed_mimes|min:1|max:$max_filesize";
return [
"mimes:{$allowed_mimes}",
"min:1",
"max:{$max_filesize}",
new FilenameLengthRule(maxLength: 200),
];
}

public function uploadedImageMessages(string $rule): string
Expand Down
25 changes: 25 additions & 0 deletions app/Rules/FilenameLengthRule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
<?php

namespace App\Rules;

use Closure;
use Illuminate\Contracts\Validation\ValidationRule;
use Illuminate\Http\UploadedFile;

class FilenameLengthRule implements ValidationRule
{
public function __construct(private int $maxLength = 100) {}

public function validate(string $attribute, mixed $value, Closure $fail): void
{
if (! $value instanceof UploadedFile) {
return;
}

$name = $value->getClientOriginalName();

if (strlen($name) > $this->maxLength) {
$fail("The :attribute filename must not exceed {$this->maxLength} characters.");
}
}
}
7 changes: 7 additions & 0 deletions resources/views/profiles/edit/information.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@
<label for="file">Icon</label>
<img id="file-img" class="profile_photo" src="{{ $profile->imageUrl }}" />
<br />
<small class="form-text text-muted"> Image requirements <a role="button" tabindex="0" aria-label="image requirements information" data-toggle="popover" data-trigger="focus" data-popover-content="#img-rules"><i class="fas fa-question-circle"></i></a></small>
<div id="img-rules" style="display:none">
<p class="m-1"><small>Supported file types: JPEG, PNG, GIF, BMP, SVG, and WebP.</small></p>
<p class="m-1"><small>Maximum file size: 10 MB.</small></p>
<p class="m-1"><small>Maximum file name lentgh: 200 characters.</small></p>
</div>
<br />
<div class="control-group">
<div class="controls">
Expand All @@ -24,6 +30,7 @@
<label for="banner">Banner</label>
<img id="banner-img" class="profile_photo" src="{{ $profile->banner_url }}" />
<br />
<small class="form-text text-muted"> Image requirements <a role="button" tabindex="0" aria-label="image requirements information" data-toggle="popover" data-trigger="focus" data-popover-content="#img-rules"><i class="fas fa-question-circle"></i></a></small>
<br />
<div class="control-group">
<div class="controls">
Expand Down
8 changes: 7 additions & 1 deletion resources/views/profiles/edit/news.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,20 @@
<label for="data[{{ $news->id }}][image]-img">Image</label>
<img class="uploaded-image w-100 d-flex" id="data[{{ $news->id }}][image]-img"
src="@if ($news->imageUrl != asset('/img/default.png')) {{ $news->imageUrl }} @endif">
<div class="custom-file form-control">
<div class="custom-file form-control" style="margin-bottom: 0px!important;">
<input type="file" id="data[{{ $news->id }}][image]" name="data[{{ $news->id }}][image]"
accept="image/*" class="custom-file-input clickable">
<label id="label-{{ $news->id }}" for="data[{{ $news->id }}][image]"
class="custom-file-label">
{{ $news->image->file_name ?? 'Select an image' }}
</label>
</div>
<small class="form-text text-muted"> Image requirements <a role="button" tabindex="0" aria-label="image requirements information" data-toggle="popover" data-trigger="focus" data-popover-content="#img-rules"><i class="fas fa-question-circle"></i></a></small>
<div id="img-rules" style="display:none">
<p class="m-1"><small>Supported file types: JPEG, PNG, GIF, BMP, SVG, and WebP.</small></p>
<p class="m-1"><small>Maximum file size: 10 MB.</small></p>
<p class="m-1"><small>Maximum file name lentgh: 200 characters.</small></p>
</div>
@foreach ($errors->get("data.{$news->id}.image") as $image_error)
@include('alert', ['message' => $image_error, 'type' => 'danger'])
<p class="d-block invalid-feedback"><i class="fas fa-asterisk"></i> {!! $image_error !!}</p>
Expand Down
Loading