Skip to content

Feat: Param aliases#252

Merged
ChiragAgg5k merged 5 commits intomainfrom
feat-param-aliases
May 5, 2026
Merged

Feat: Param aliases#252
ChiragAgg5k merged 5 commits intomainfrom
feat-param-aliases

Conversation

@Meldiron
Copy link
Copy Markdown
Contributor

@Meldiron Meldiron commented May 4, 2026

No description provided.

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented May 4, 2026

Greptile Summary

  • Introduces parameter aliases in getArguments: when a canonical param key is absent from either requestParams or values, the code iterates the alias list and uses the first matching key. Path-param priority over query params is preserved through independent lookups.
  • utopia-php/servers is updated from 0.3.* to the stable 0.4.0 release, addressing the previously flagged dev-branch dependency.
  • Test coverage is thorough across GET/POST, URL-path alias mapping, canonical-wins, first-alias-wins, default fallback, required-param errors, and validation error reporting.

Confidence Score: 5/5

Safe to merge — logic is correct, stable dependency pinned, and test coverage is comprehensive.

No P0 or P1 findings. The alias resolution preserves existing precedence rules, and the previous dev-branch concern is now resolved with a pinned 0.4.0 release.

No files require special attention.

Important Files Changed

Filename Overview
src/Http/Http.php Adds alias-aware key resolution in getArguments; logic is correct, preserving path-param > query-param > default priority through independent lookups for both values and requestParams.
tests/HttpTest.php Adds testCanResolveParamAliases covering 9 cases: GET/POST alias resolution, canonical-wins priority, first-alias-wins ordering, default fallback, required-param error, validation error, URL-path alias, and path-over-query precedence.
composer.json Bumps utopia-php/servers from 0.3.* to 0.4.0, resolving the previously flagged dev-branch dependency issue.
composer.lock Lock file updated to reflect utopia-php/servers 0.4.0 stable release with pinned git reference.

Reviews (3): Last reviewed commit: "Use stable servers 0.4.0" | Re-trigger Greptile

Comment thread composer.json Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

k6 benchmark

Throughput Requests Fail rate p50 p95
5611 req/s 392872 0% 7.28 ms 15.63 ms

@ChiragAgg5k ChiragAgg5k merged commit 76be330 into main May 5, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants