Skip to content

nice -n . 2>/dev/full does not abort#10762

Open
oech3 wants to merge 1 commit intouutils:mainfrom
oech3:nice-abort
Open

nice -n . 2>/dev/full does not abort#10762
oech3 wants to merge 1 commit intouutils:mainfrom
oech3:nice-abort

Conversation

@oech3
Copy link
Contributor

@oech3 oech3 commented Feb 6, 2026

Closes #10747 . Removes Try --help message which matches with gnu 9.10.

@github-actions
Copy link

github-actions bot commented Feb 6, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/shuf/shuf-reservoir (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/sort/sort-stale-thread-mem (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/basenc/bounded-memory is now passing!

@oech3 oech3 marked this pull request as ready for review February 6, 2026 05:53
@github-actions
Copy link

github-actions bot commented Feb 6, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/usage_vs_getopt (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)

// We can't use `show_warning` because that will panic if stderr
// isn't writable. The GNU test suite checks specifically that the
// exit code when failing to write the advisory is 125, but Rust
// will produce an exit code of 101 when it panics.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should cleanup this too.

@github-actions
Copy link

github-actions bot commented Feb 7, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)

@oech3 oech3 force-pushed the nice-abort branch 2 times, most recently from 7d222d9 to 3b4e61b Compare February 8, 2026 15:55
@oech3

This comment was marked as resolved.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 8, 2026

CodSpeed Performance Report

Merging this PR will improve performance by 3.24%

Comparing oech3:nice-abort (4da30c3) with main (1f4a976)

Summary

⚡ 2 improved benchmarks
✅ 282 untouched benchmarks
⏩ 38 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation unexpand_many_lines[100000] 300.6 ms 291.1 ms +3.23%
Simulation unexpand_large_file[10] 630.1 ms 610.4 ms +3.24%

Footnotes

  1. 38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions
Copy link

github-actions bot commented Feb 8, 2026

GNU testsuite comparison:

Congrats! The gnu test tests/pr/bounded-memory is no longer failing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nice -n . 2>/dev/full SIGABRT

3 participants