sort: remove procfs dependency and fix percent parsing bugs in parse_size#10806
Open
ChrisDryden wants to merge 2 commits intouutils:mainfrom
Open
sort: remove procfs dependency and fix percent parsing bugs in parse_size#10806ChrisDryden wants to merge 2 commits intouutils:mainfrom
ChrisDryden wants to merge 2 commits intouutils:mainfrom
Conversation
29230a2 to
88dbe19
Compare
sylvestre
reviewed
Feb 8, 2026
CodSpeed Performance ReportMerging this PR will improve performance by 3.51%Comparing Summary
Performance Changes
Footnotes
|
Contributor
|
Some jobs are failing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were quite a few bugs in the implementation of the memory sorting option and it was not working as expected outlined in: #10803 I started investigating it to see if it was possible to remove this dependency because it brings in a bunch of other dependencies like chronos and we only use the procfs dependency just for this one function.
When I investigated how this function was implemented, it was simply reading the file iterating through all of the lines and splitting. Whats great is that since it wasn't working in the first place it means that theres no way this PR could introduce a regression.
These are all of the dependencies that would be removed from all of the parse_size users:
Fixes: #10803