false: dedup set_exit_code(1)#10823
Merged
ChrisDryden merged 1 commit intouutils:mainfrom Feb 8, 2026
Merged
Conversation
|
GNU testsuite comparison: |
ChrisDryden
reviewed
Feb 8, 2026
| // and the interrupted display of help and version should return `1`. Also, we return Ok in all | ||
| // paths to avoid the allocation of an error object, an operation that could, in theory, fail | ||
| // and unwind through the standard library allocation handling machinery. | ||
| set_exit_code(1); |
Collaborator
There was a problem hiding this comment.
Just putting a note for future reference that this is why the set_exit_code is redundant
Collaborator
|
Thanks, the style of this utility in particular gets a bunch of visibility as a comparison |
oech3
added a commit
to oech3/coreutils
that referenced
this pull request
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.