Fix Intermittent tests/date/date-locale-hour.sh by sylvestre · Pull Request #11497 · uutils/coreutils

sylvestre · 2026-03-25T22:13:38Z

No description provided.

github-actions · 2026-03-25T22:28:12Z

GNU testsuite comparison:

Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/tail/tail-n0f is now passing!

codspeed-hq · 2026-03-25T22:38:03Z

Merging this PR will not alter performance

✅ 309 untouched benchmarks
⏩ 46 skipped benchmarks¹

_{Comparing sylvestre:intermitten-date-locale-hour (e23df9b) with main (bfdf580)}

46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

github-actions · 2026-04-05T20:56:57Z

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/date/resolution (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/tail/pipe-f is now being skipped but was previously passing.
Congrats! The gnu test tests/seq/seq-epipe is now passing!

github-actions · 2026-04-06T09:53:11Z

GNU testsuite comparison:

Note: The gnu test tests/tail/pipe-f is now being skipped but was previously passing.
Congrats! The gnu test tests/pr/bounded-memory is now passing!
Congrats! The gnu test tests/seq/seq-epipe is now passing!

github-actions · 2026-04-06T13:30:04Z

GNU testsuite comparison:

Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/cut/cut-huge-range is now being skipped but was previously passing.

cakebaker · 2026-04-06T14:18:53Z

+    let stdout_bytes = result.stdout();
+    assert_eq!(stdout_bytes[0], 0xFF);
+    assert_eq!(&stdout_bytes[1..3], b"10");


You can simplify it by using stdout_is_bytes:

.succeeds() .stdout_is_bytes(b"\xFF10\n");

cakebaker · 2026-04-06T14:20:36Z

+    let stdout_bytes = result.stdout();
+    // \xC4\xEA + "10" + \xD4\xC2 + "11" + \xC8\xD5 + "\n"
+    assert_eq!(stdout_bytes, b"\xc4\xea10\xd4\xc211\xc8\xd5\n");


The same here.

cakebaker · 2026-04-06T14:34:59Z

    utc: bool,
    format: Format,
+    /// Raw format bytes for Custom format, to preserve non-UTF-8 bytes in output
+    format_raw: Option<Vec<u8>>,


Why do you introduce an additional property instead of adapting the Format enum?

cakebaker · 2026-04-06T14:58:00Z

            return Err(USimpleError::new(
                1,
-                translate!("date-error-extra-operand", "operand" => format_args[1]),
+                translate!("date-error-extra-operand", "operand" => format_args[1].to_string_lossy()),


GNU date doesn't use a lossy string in this case. But it is only an error message so it depends on how close we want to be to GNU date.

$ date -d "2025-12-16" +%m $'+\xFF%Y' date: extra operand ‘+\377%Y’

github-actions · 2026-04-06T15:03:41Z

GNU testsuite comparison:

Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)

cakebaker · 2026-04-06T15:04:20Z

+    let format = if let Some(form) = matches.get_one::<OsString>(OPT_FORMAT) {
+        let raw_bytes = form.as_encoded_bytes();
+        if raw_bytes.first() != Some(&b'+') {
+            let form_lossy = form.to_string_lossy();


The same here.

github-actions · 2026-04-06T20:17:30Z

GNU testsuite comparison:

GNU test failed: tests/tail/pipe-f2. tests/tail/pipe-f2 is passing on 'main'. Maybe you have to rebase?
Note: The gnu test tests/basenc/bounded-memory is now being skipped but was previously passing.

Fixes intermittent: tests/date/date-locale-hour.sh The GNU test date-locale-hour.sh picks 10 random locales via `locale -a | shuf -n 10`. In CI, zh_CN.GB18030 is installed and its date_fmt contains Chinese characters (年, 月, 日) encoded in GB18030, which is not valid UTF-8.

github-actions · 2026-04-12T15:54:16Z

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/tail-n0f (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/basenc/bounded-memory is now passing!

sylvestre marked this pull request as ready for review March 26, 2026 07:56

cakebaker reviewed Mar 26, 2026

View reviewed changes

Comment thread src/uu/date/src/date.rs Outdated

sylvestre force-pushed the intermitten-date-locale-hour branch 2 times, most recently from c4d86ed to e66702c Compare April 5, 2026 20:34

sylvestre requested a review from cakebaker April 6, 2026 09:33

sylvestre force-pushed the intermitten-date-locale-hour branch from 84bbc0d to 857d820 Compare April 6, 2026 13:23

cakebaker reviewed Apr 6, 2026

View reviewed changes

sylvestre force-pushed the intermitten-date-locale-hour branch from 857d820 to a25d90b Compare April 6, 2026 14:33

cakebaker reviewed Apr 6, 2026

View reviewed changes

sylvestre added 5 commits April 12, 2026 17:46

date: add test for non-UTF-8 locale format handling (zh_CN.GB18030)

86dbb88

date: preserve non-UTF-8 bytes in format string output

3b3378b

Update spell-checker ignore list in date.rs

9b29a7b

date: move raw format bytes into Format::Custom enum variant

e23df9b

sylvestre force-pushed the intermitten-date-locale-hour branch from 7ac2d9b to e23df9b Compare April 12, 2026 15:46

Uh oh!

Conversation

sylvestre commented Mar 25, 2026

Uh oh!

github-actions bot commented Mar 25, 2026

Uh oh!

codspeed-hq bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

Uh oh!

github-actions bot commented Apr 5, 2026

Uh oh!

github-actions bot commented Apr 6, 2026

Uh oh!

github-actions bot commented Apr 6, 2026

Uh oh!

cakebaker Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

cakebaker Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

cakebaker Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

cakebaker Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 6, 2026

Uh oh!

cakebaker Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 6, 2026

Uh oh!

github-actions bot commented Apr 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codspeed-hq bot commented Mar 25, 2026 •

edited

Loading