fix: prevent default on Escape key when closing overlay#11090
Draft
fix: prevent default on Escape key when closing overlay#11090
Conversation
On macOS, pressing Escape in a fullscreened browser window causes the browser to exit fullscreen mode. When an overlay (e.g., dialog) closes on Escape, the key event should be consumed by calling preventDefault() to prevent the browser from also handling it. https://claude.ai/code/session_01CsvF5ewbUGirKySHMfzdRp
Verify that the Escape keydown event has its default prevented when the overlay closes, and that it is not prevented when the vaadin-overlay-escape-press event is cancelled. https://claude.ai/code/session_01CsvF5ewbUGirKySHMfzdRp
|
Contributor
|
This might affect behaviour of other components / shortcuts, need to be verified. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS, pressing Escape in a fullscreened browser window causes the
browser to exit fullscreen mode. When an overlay (e.g., dialog) closes
on Escape, the key event should be consumed by calling preventDefault()
to prevent the browser from also handling it.
https://claude.ai/code/session_01CsvF5ewbUGirKySHMfzdRp