chore: mark readOnly properties in CEM analyzer config#11181
Merged
web-padawan merged 2 commits intomainfrom Mar 4, 2026
Merged
chore: mark readOnly properties in CEM analyzer config#11181web-padawan merged 2 commits intomainfrom
web-padawan merged 2 commits intomainfrom
Conversation
Add readonlyPlugin() that detects `readOnly: true` in `static get properties()` and sets `readonly: true` on the corresponding CEM member declarations. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
# Conflicts: # custom-elements-manifest.config.js
|
sissbruecker
approved these changes
Mar 4, 2026
Collaborator
|
This ticket/PR has been released with Vaadin 25.1.0-beta2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added
readonlyPlugin()that detectsreadOnly: trueinstatic get properties()and setsreadonly: trueon the corresponding CEM member declarations.This will allow us to remove bindings like
.itemsfromweb-types-lit.jsonwhen switching web types to use CEM.Using
cem-plugin-readonlyis not an option as it doesn't supportreadOnly: truesyntax, only getters / JSDoc.Type of change