ensure mode is always set to INITIAL during startTokenization#119
Merged
hsivonen merged 1 commit intoMay 13, 2026
Conversation
While currently, all branches set a mode, this is both subtle and fragile; if a branch ends up not setting mode it will never be reset. This means subsequent calls to start tokenisation can end up with a different initial mode. This change simply resets mode to INITIAL on every startTokenization() call, ensuring that if we ever miss it, it will be reset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While currently, all branches set a mode, this is both subtle and fragile; if a branch ends up not setting mode it will never be reset. This means subsequent calls to start tokenisation can end up with a different initial mode.
This change simply resets mode to INITIAL on every startTokenization() call, ensuring that if we ever miss it, it will be reset.