fix(retain): preserve normalized experience fact types#839
Closed
Rutimka wants to merge 1 commit intovectorize-io:mainfrom
Closed
fix(retain): preserve normalized experience fact types#839Rutimka wants to merge 1 commit intovectorize-io:mainfrom
Rutimka wants to merge 1 commit intovectorize-io:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
experiencefact types in both retain conversion pathsProblem
PR #775 taught the extractor to normalize first-person agent facts from raw
assistantoutput toexperience, but the laterExtractedFactTypeconversion still re-checked for the rawassistantlabel. By that point the fact type was already normalized, soexperiencefacts were being remapped back toworld.Testing
env UV_CACHE_DIR=/tmp/uv-cache uv run ruff check hindsight_api/engine/retain/fact_extraction.py tests/test_fact_extraction_experience_regression.pyenv UV_CACHE_DIR=/tmp/uv-cache RUFF_CACHE_DIR=/tmp/ruff-cache uv run ruff format --check hindsight_api/engine/retain/fact_extraction.py tests/test_fact_extraction_experience_regression.pyenv UV_CACHE_DIR=/tmp/uv-cache uv run pytest tests/test_fact_extraction_experience_regression.py -v