Skip to content

Conversation

@scubbo
Copy link

@scubbo scubbo commented Jun 12, 2025

Extracted from here, initially so it can be used in slack-metrics-preset (as here), and potentially other repos.

There's some discussion here about where to locate reusable workflows. Technically, Composite Actions and Reusable Workflows are different things, but they're similar enough that the decisions about how to organize them will likely have the same answer for both.

Extraction of common CI workflows allows the best-of-both-worlds of a monorepo and a polyrepo:

  • Those who work on a monorepo can continue enjoying the benefits of cross-domain changes, atomic commits, and single consistent versions.
  • Those who work in other repos can still benefit from centrally-provided workflow tooling, without having to "roll their own"
    (EDIT: To be explicit - if this is merged, I would then advocate for removing .github/composite-actions/install from vercel/api, and replacing usages with a reference to this external definition)

Extracted from
[here](https://github.com/vercel/api/blob/main/.github/composite-actions/install/action.yml),
initially so it can be used in `slack-metrics-preset` (as
[here](vercel/slack-metrics-preset#288)).

There's some discussion
[here](https://vercel.slack.com/archives/C03S5U5AA93/p1749562929687589?thread_ts=1749560645.436149&cid=C03S5U5AA93)
about where to locate reusable workflows. Technically, [Composite
Actions and Reusable Workflows are different
things](https://dev.to/n3wt0n/github-composite-actions-vs-reusable-workflows-updated-2023-bl8),
but they're similar enough that the decisions about how to organize them
will likely have the same answer for both.
@scubbo scubbo requested a review from bkonkle June 12, 2025 20:20
@scubbo scubbo marked this pull request as ready for review June 12, 2025 20:20
@scubbo scubbo closed this Jun 12, 2025
Copy link

@krsjenswbp krsjenswbp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@gitme1-ym
Copy link

Extracted from here, initially so it can be used in slack-metrics-preset (as here), and potentially other repos.

There's some discussion here about where to locate reusable workflows. Technically, Composite Actions and Reusable Workflows are different things, but they're similar enough that the decisions about how to organize them will likely have the same answer for both.

Extraction of common CI workflows allows the best-of-both-worlds of a monorepo and a polyrepo:

  • Those who work on a monorepo can continue enjoying the benefits of cross-domain changes, atomic commits, and single consistent versions.
  • Those who work in other repos can still benefit from centrally-provided workflow tooling, without having to "roll their own"
    (EDIT: To be explicit - if this is merged, I would then advocate for removing .github/composite-actions/install from vercel/api, and replacing usages with a reference to this external definition)

#8 (comment)

Copy link

@gitme1-ym gitme1-ym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants