Add isExternalChannel support to Thread, Channel, and Slack adapter#51
Open
Add isExternalChannel support to Thread, Channel, and Slack adapter#51
Conversation
Co-authored-by: Fernando Rojo <13172299+nandorojo@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Contributor
Preview Branch TestingTo test this PR with real webhook traffic:
To disable: Clear the URL on the settings page. |
Co-authored-by: Fernando Rojo <13172299+nandorojo@users.noreply.github.com>
# Conflicts: # packages/adapter-slack/src/index.ts # packages/chat/src/channel.ts # packages/chat/src/serialization.test.ts # packages/chat/src/thread.ts # packages/chat/src/types.ts
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
|
@nandorojo updated this branch for ye |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slack Connect channels can leak internal context (repo summaries, etc.) to external organizations. This adds
isExternalChannel: booleanto the SDK so consumers can gate behavior based on whether a thread is in an externally shared channel.What changed
isExternalChannel?(threadId)method to theAdapterinterface, following the same pattern asisDM?readonly isExternalChannel: booleantoPostable,Thread, andChannelinterfaces and their implementations (ThreadImpl,ChannelImpl)isExternalChanneltoThreadInfo,ChannelInfo, andSerializedThread/SerializedChannelfor serialization supportChat.createThread()now callsadapter.isExternalChannel?.(threadId) ?? falseand passes it throughis_ext_shared_channelfrom the webhook payload envelope and caches it per channel ID in aSet. Also readsis_ext_sharedfromconversations.infoAPI responses infetchThreadandfetchChannelInfo. ImplementsisExternalChannel(threadId)that checks the cache.false.v0/plans/add-is-external-channel.mdAll 358 tests pass.