Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Preview Branch TestingTo test this PR with real webhook traffic:
To disable: Clear the URL on the settings page. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
Comment on lines
+201
to
+202
| await this.locks.delete(lock.threadId); | ||
| } catch (error) { |
Contributor
There was a problem hiding this comment.
Suggested change
| await this.locks.delete(lock.threadId); | |
| } catch (error) { | |
| // Use version-checked update instead of unversioned delete to avoid | |
| // racing with another process that acquired the lock between our read | |
| // and this write. Setting expiresAt to 0 marks it as expired so | |
| // acquireLock will treat it as available. | |
| await existing.update({ | |
| token: value.token, | |
| expiresAt: 0, | |
| }); | |
| } catch (error) { | |
| if (error instanceof KVVersionConflictError) { | |
| // Another process already took over the lock — safe to ignore | |
| return; | |
| } |
Race condition in releaseLock: unversioned this.locks.delete() can delete another process's lock that was acquired between the token check and the delete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan