Added new comparators: (not_)contains and case-insensitive versions#288
Open
vincent-derks wants to merge 5 commits intocontrolfrom
Open
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
vincent-derks
force-pushed
the
vincentderks/fla-2506-add-contains-and-matches-operators-case-insensitive
branch
from
8cf223e to
36f74f9
Compare
vincent-derks
force-pushed
the
vincentderks/fla-2506-add-contains-and-matches-operators-case-insensitive
branch
from
89c0b52 to
a1bd4ef
Compare
vincent-derks
force-pushed
the
vincentderks/fla-2506-add-contains-and-matches-operators-case-insensitive
branch
from
a1bd4ef to
55a35cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
containsoperator and case-insensitive comparatorsSummary
CONTAINSandNOT_CONTAINScomparators for substring matching[LHS, Comparator, RHS, { ci: true }]Backwards compatibility
The 4th-element approach was chosen specifically for backwards compat. Old SDKs destructure only 3 elements from the condition tuple, so
{ ci: true }is silently ignored and the condition evaluates case-sensitively (graceful degradation). New comparators likeCONTAINSfall through todefaultand returnfalseon old SDKs -- no crash, just a skipped rule.