Validate FLAGS_SECRET length for precompute JWS codes#380
Open
OWConnoi wants to merge 1 commit into
Open
Conversation
Contributor
|
@OWConnoi is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This aligns precompute JWS signing/verification with the documented
FLAGS_SECRETrequirement by rejecting secrets that do not decode to 32 bytes.Why
The JWE helpers already enforce a 256-bit key. Precompute serialization used the decoded secret directly for HS256, so accidentally short secrets were accepted. Using the same validation here makes misconfiguration fail early and keeps the secret handling consistent across the package.
Tests
npx --yes pnpm@10.19.0 --filter flags testnpx --yes pnpm@10.19.0 --filter flags checknpx --yes pnpm@10.19.0 --filter flags type-check