docs: document dispatch-input hardening and pr_number lifecycle#98
Draft
github-actions[bot] wants to merge 1 commit intomainfrom
Draft
docs: document dispatch-input hardening and pr_number lifecycle#98github-actions[bot] wants to merge 1 commit intomainfrom
github-actions[bot] wants to merge 1 commit intomainfrom
Conversation
- catalog/agent-team/README.md: add `pr_number` lifecycle section to the handoff model (blank on first impl → creates PR; reviewer passes it back on kickback → implementer pushes to existing branch). Expand "Input propagation" gotcha with the exact error message, unresolved-literal detection, and the optional-by-design note for pr_number. - CONTRIBUTING.md: replace "no automated test harness" with the actual tiered test strategy (tier-2 invariants, tier-1 skill tests, tier-3 E2E) and clear guidance on when to run each tier. Follows PR #69 (fix agent-team dispatch-input hardening). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #69 (fix agent-team manual workflow_dispatch inputs).
What changed
catalog/agent-team/README.mdNew
pr_numberlifecycle section (under The handoff model):Explains the two-state flow that was implicit in the workflow files but absent from the high-level README:
pr_numberis blank → implementer creates a new draft PRpr_numberback → implementer pushes to the existing branch, not a new oneWithout this, users manually retrying a kickback stage couldn't tell whether to supply a
pr_numberor leave it blank.Expanded "Input propagation" gotcha (under Limits and gotchas):
Old one-liner only said "fail loudly". New text adds:
🛑 agent-team: workflow_dispatch inputs were not propagated. Re-dispatch with valid inputs.)$\{\{ github.event.inputs.issue_number }}) are treated the same as missing — the surface-level behavior that PR [codex] fix agent-team manual workflow_dispatch inputs #69 hardenedpr_numberis optional by design and handled speciallyCONTRIBUTING.mdReplaced "no automated test harness" with the actual tiered test strategy.
The old text was incorrect — the repo ships three test tiers and CI runs two of them on every PR. New section provides a quick-reference table and guidance on when to run each tier.
Testing