refactor nebula client and nebula pool & add async interface & add tests #414
Conversation
| def __post_init__(self): | ||
| """Initialize auth_options with password if provided""" | ||
| if self.password: | ||
| self.auth_options["password"] = self.password |
There was a problem hiding this comment.
how about use provides the password and auth info in the same time?
There was a problem hiding this comment.
password和auth_options可以同时配置，对于password则以password中的配置值为准。
| for addr in addresses.split(","): | ||
| addr = addr.strip() | ||
| if ":" in addr: | ||
| host, port = addr.rsplit(":", 1) |
There was a problem hiding this comment.
could we use ipaddress to support ipv6?
There was a problem hiding this comment.
当前pr没有处理ipv6，有单独的支持ipv6的issue在
| with self._lock: | ||
| # Try to find an available client | ||
| for client in self._pool: | ||
| if not self._in_use.get(client, False): |
There was a problem hiding this comment.
if self._in_use.get(client):
continue
| # Try to find an available client | ||
| for client in self._pool: | ||
| if not self._in_use.get(client, False): | ||
| if self.config.test_on_borrow: |
There was a problem hiding this comment.
if self.config.test_on_borrow and self._factory.validate(client):
| return | ||
|
|
||
| with self._lock: | ||
| if client in self._in_use: |
There was a problem hiding this comment.
if client not in self._in_use, should close it and then remove from pool
There was a problem hiding this comment.
if client not in use, means the client already be returned to pool, cannot remove and close it.
3 participants
close #404 #403
基于5.0 sdk的设计 重构python sdk：