Skip to content

fix: session leak on re-auth and init failure #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xguo-jpg wants to merge 1 commit into
base: release-5.2
Choose a base branch
from
Open

fix: session leak on re-auth and init failure #416

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/nebulagraph_python/client/_connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,22 +494,22 @@ async def authenticate(
request, timeout=self.config.request_timeout
)
except grpc.aio.AioRpcError as e:
self.close()
await self.close()
logger.error(
f"Async RPC error during authenticate: {e.code()} {e.details()}"
)
raise AuthenticatingError(
f"RPC error during authentication: {e.details()}"
) from e
except Exception as e: # Catch other potential errors
self.close()
await self.close()
logger.error(f"Unexpected error during async authenticate: {e}")
raise AuthenticatingError(
"Unexpected error during async authentication"
) from e

if response.status.code != b"00000":
self.close()
await self.close()
raise NebulaGraphRemoteError(
code=ErrorCode(response.status.code.decode("utf-8")),
message=response.status.message.decode("utf-8"),
Expand Down