Conversation
This reverts commit f9955dd.
- added GroupedServiceNames field - added more unit tests for AddService and RemoveService
- added GroupedServiceNames field - added more unit tests for AddService and RemoveService
|
I hope I'll have time to review this on Friday. Maybe @thomasjpfan can go through it sooner. |
|
An implementation that would change the least amount of code would be to add a type Data struct {
Services map[string]Service
GroupServices map[string][]Service
}And handle the |
|
There is no enough space for running the tests: No space left on device. |
|
There was a problem with the latest haproxy release. It's resolved by specifying a fixed version in Dockerfile. If you merge your code with the master branch, it should work or, at least, not fail for the same reason. |
|
I have just merged it with the upstream. |
|
Please take a look at https://jenkins.dockerflow.com/blue/organizations/jenkins/vfarcic%2Fdocker-flow-proxy/detail/PR-440/7/pipeline/ . Some of the integration tests are failing with those changes. I'll do my best to review the changes as soon as possible. However, given my current agenda, I might not be able to do that before the upcoming weekend. I hope that's OK. |
In this step we have added support for implementing the grouped services.
No functionality has been changed.