Fix (actually block) GAF upload #470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsupported, and allow upload errors to reach the user in an ugly way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't currently sort and index GAF files on upload (until vg fixes vgteam/vg#4521).
This locks them out of the file upload picker, makes an unimplemented error in the upload handler to catch them, and adds some not-very-pretty but functional support for showing an error when an upload fails or is rejected.
We should fix vg to support writing GAF indexes (or ship
tabixandbgzipas tube map dependencies?) and turn the uploads on again.We need to use
.gafand.gzas the upload filters when we do;.gaf.gzdoesn't actually work since you can only match the last extension in the file picker.