Scoring Refactor#4898
Open
adamnovak wants to merge 21 commits into
Open
Conversation
…he scoring and MAPQ stuff into their own classes
…mise to give you a score matrix
…r QualAdjAlignmentScorer
…cover the log base immediately
… give the GC content to both scorers.
… casting accessor that just went around the intended interface
Member
Author
|
I think this is finally really ready; I've removed all the things that Anthropic Claude wanted me to do that I don't actually want to do, after several passes and several days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
To be copied to the draft changelog by merger:
GSSWAlignerand moved toAlignmentScorerandMappingQualityCalculator.Description
This breaks the alignment-scoring and mapping quality computation responsibilities off of the aligner class hierarchy and gives them their own class hierarchies.
Now there's alignment scorers for normal, quality-adjusted, and Minimap2-style logged-gap approaches. Each of them knows how to produce the "log base" that we use for mapping quality computation and hand it off to the MAPQ calculator. The aligners can use the appropriate ones of these scoring classes for the actual DP.
A lot of this code was synthesized via Anthropic Claude, and I've gone over most of it to try and make it acceptable.
This should produce exactly the same answers as before.